Skip to content

Add an error dialog that is displayed if there is an error when exporting artwork #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0HyperCube
Copy link
Member

If an error is encountered during export, the error dialogue should be shown. However currently it is not. This is due to the fact that the export dialogue puts a FrontendMessage::DisplayDialogDismiss after running the exporting process, causing the error to be immediately dismissed.

Also

  • refactor preferences message handler to reduce duplication
  • remove some unnecessary allocations

@0HyperCube 0HyperCube force-pushed the export-error-dialogue branch from 7dfa5d4 to df304b7 Compare August 4, 2025 20:08
@0HyperCube 0HyperCube mentioned this pull request Aug 7, 2025
@Keavon Keavon changed the title Display error dialogue when exporting Add an error dialog that is displayed if there is an error when exporting artwork Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant