-
Notifications
You must be signed in to change notification settings - Fork 413
feat(mito): backfill partition expr on region open #6862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af7952c
to
1d992e8
Compare
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
1d992e8
to
35a064d
Compare
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
db87ee1
to
8ab1e74
Compare
fengjiachun
approved these changes
Sep 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
evenyag
reviewed
Sep 2, 2025
WenyXu
reviewed
Sep 2, 2025
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
970a65f
to
2f98ea0
Compare
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
7f17b2b
to
2e84da8
Compare
evenyag
reviewed
Sep 5, 2025
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
WenyXu
reviewed
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
WenyXu
approved these changes
Sep 9, 2025
waynexia
pushed a commit
to waynexia/greptimedb
that referenced
this pull request
Sep 9, 2025
* feat(mito): backfill partition expr on region open Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * tiny polish Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * only writable leader persists Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * catchup needs backfill Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * add log Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * handle distribute mode Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * only when transfer to set gracefully Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * fix fmt Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> --------- Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Older regions didn’t persist partition_expr in engine metadata; new regions do. To unify behavior and support online upgrade, we backfill
partition_expr
on region open and persist it to the manifest.Added on-open backfill to persist
partition_expr
for legacy regions.Backfill runs only when
metadata.partition_expr
is None; no impact on regions already carrying the field.Manual Test
SQL on release/0.15
manifests:
Restart with this patch, manifests:
PR Checklist
Please convert it to a draft if some of the following conditions are not met.