Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge toolsHCK into rtoolsHCK to prevent version mismatch #50

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Merge toolsHCK into rtoolsHCK to prevent version mismatch #50

merged 1 commit into from
Sep 2, 2024

Conversation

Jedoku
Copy link
Contributor

@Jedoku Jedoku commented Aug 19, 2024

No description provided.

@Jedoku Jedoku force-pushed the Merge-toolsHCK-into-rtoolsHCK-to-prevent-version-mismatch-debuging branch from c71cd1f to 67ac6d8 Compare August 21, 2024 08:26
akihikodaki
akihikodaki requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@akihikodaki akihikodaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is beneficial to have two levels (shared and tools for toolsHCK. I also don't know what shared means.

@Jedoku
Copy link
Contributor Author

Jedoku commented Aug 22, 2024 •
edited
Loading

I don't think it is beneficial to have two levels (shared and tools for toolsHCK. I also don't know what shared means.

how about
`extras/

  • toolsHCK.ps1
  • LICENSE.toolsHCK
  • README.toolsHCK.md`

@akihikodaki
Copy link
Contributor

I don't think it is beneficial to have two levels (shared and tools for toolsHCK. I also don't know what shared means.

how about `extras/

extras is misleading. They are not extras, but essential part of rtoolsHCK.

* toolsHCK.ps1

* LICENSE.toolsHCK

LICENSE.toolsHCK is redundant and unnecessary.

* README.toolsHCK.md`

@akihikodaki
Copy link
Contributor

README.md also needs to be updated as it refers to toolsHCK in a separate repository.

@Jedoku Jedoku force-pushed the Merge-toolsHCK-into-rtoolsHCK-to-prevent-version-mismatch-debuging branch 2 times, most recently from bb5001f to 3c22a0c Compare August 26, 2024 09:27
@Jedoku Jedoku requested a review from akihikodaki August 26, 2024 13:15
akihikodaki
akihikodaki requested changes Aug 26, 2024
View reviewed changes
lib/rtoolsHCK.rb Outdated
@@ -134,7 +134,7 @@ def logger(level, progname = nil, &)
# the local machine
# (default: disabled)
# :l_script_file - The toolsHCK.ps1 file path on local machine
# (default: disabled)
# (default: shared/tools/toolsHCK.ps1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an update.

I also suggest removing l_script_file option and hardcoding the path. We do not want to mix different toolsHCK and rtoolsHCK.

@Jedoku Jedoku force-pushed the Merge-toolsHCK-into-rtoolsHCK-to-prevent-version-mismatch-debuging branch from 3c22a0c to e554127 Compare August 28, 2024 05:11
akihikodaki
akihikodaki requested changes Aug 28, 2024
View reviewed changes
lib/rtoolsHCK.rb Outdated
@@ -144,6 +142,8 @@ def initialize(init_opts)
@log_to_stdout = init_opts[:log_to_stdout]
@stdout_logger = Logger.new($stdout) if @log_to_stdout
@logger = init_opts[:logger]
@l_script_file = File.expand_path('../shared/tools/toolsHCK.ps1', __dir__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It no longer has to be kept as an instance variable of RToolsHCK. We can hardcode it at Server#deploy_script_file, which actually uses it.

@Jedoku Jedoku force-pushed the Merge-toolsHCK-into-rtoolsHCK-to-prevent-version-mismatch-debuging branch from e554127 to 20db53a Compare August 28, 2024 20:35
@Jedoku Jedoku requested a review from akihikodaki August 28, 2024 20:46
akihikodaki
akihikodaki requested changes Aug 29, 2024
View reviewed changes
@Jedoku Jedoku force-pushed the Merge-toolsHCK-into-rtoolsHCK-to-prevent-version-mismatch-debuging branch from 20db53a to d1c3766 Compare August 29, 2024 06:53
@Jedoku Jedoku requested a review from akihikodaki August 29, 2024 07:09
akihikodaki
akihikodaki requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@akihikodaki akihikodaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last request: remove "debuging" from the commit message. It's "debugging", and we don't need it anyway because we want to prevent "version mismatch" itself anyway.

@Jedoku Jedoku force-pushed the Merge-toolsHCK-into-rtoolsHCK-to-prevent-version-mismatch-debuging branch from d1c3766 to 71d0cfe Compare August 29, 2024 08:08
@Jedoku Jedoku changed the title Merge toolsHCK into rtoolsHCK to prevent version mismatch debuging Merge toolsHCK into rtoolsHCK to prevent version mismatch Aug 29, 2024
@Jedoku Jedoku requested a review from akihikodaki August 29, 2024 08:10
akihikodaki
akihikodaki requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@akihikodaki akihikodaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found two minor problems. They should be truely the last things remaining.

@Jedoku
Merge toolsHCK into rtoolsHCK to prevent version mismatch
f21e050 
Signed-off-by: Vitalii Chulak <vitalii@daynix.com>
@Jedoku Jedoku force-pushed the Merge-toolsHCK-into-rtoolsHCK-to-prevent-version-mismatch-debuging branch from 71d0cfe to f21e050 Compare August 29, 2024 08:28
@Jedoku Jedoku requested a review from akihikodaki August 29, 2024 08:29
@kostyanf14 kostyanf14 merged commit a1a58fc into master Sep 2, 2024
1 check passed
@kostyanf14 kostyanf14 deleted the Merge-toolsHCK-into-rtoolsHCK-to-prevent-version-mismatch-debuging branch September 2, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihikodaki akihikodaki akihikodaki approved these changes

@kostyanf14 kostyanf14 kostyanf14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jedoku @akihikodaki @kostyanf14