Modify RobertaEmbedding forward as custom op method #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeonsily
requested review from
kzawora-intel,
madamczyk-intel,
michalkuligowski,
mgawarkiewicz,
vivekgoe and
afierka-intel
as code owners
michalkuligowski
requested changes
Apr 2, 2025
|
@kzawora-intel As @michalkuligowski is off now, can you please review this PR? Thanks. |
michalkuligowski
requested changes
Apr 7, 2025
|
@michalkuligowski @kzawora-intel Can you please advise me how you want to change this PR? Our customer waits for roberta embedding enablement. |
yeonsily
force-pushed
the
dev/enable_roberta_embedding2
branch
from
964be54 to
0ddcf15
Compare
michalkuligowski
approved these changes
Apr 10, 2025
|
/run-gaudi-tests |
|
From those two failed test logs, I see that they were actually passed but somehow couldn't exit the process normally with this message. "Received notify event: Due to an error on node g3-srv179-c03w-idc a jira ticket https://jira.habana-labs.com/browse/SW-225420 was opened, your resource vllm-fork-996-79cqyb8h7e-tfjob might be effected" I think they are not real issues. And the same PR for v1.21.0-next branch which is #1049, all CI passed on it. |
michalkuligowski
pushed a commit
that referenced
this pull request
Apr 16, 2025
Same PR as #996. Just for v1.21.0_next branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is custom op change as PR #786 follow-up.
Removed RobertaEmbedding class from model file and implemented it as CustomOp class in new file.
forward_cuda() is the original forward function and forward_hpu() is our specific change.