Node Upgrade #15037
Closed
Node Upgrade #15037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json # website/client/package-lock.json # website/client/package.json # website/client/src/components/static/faq.vue
negue
reviewed
Dec 4, 2023
| @@ -41,11 +41,11 @@ describe('POST /challenges/:challengeId/flag', () => { | |||
| }); | |||
|
|
|||
| it('flags a challenge with a higher count when from an admin', async () => { | |||
| await user.update({ 'contributor.admin': true }); | |||
| const admin = await generateUser({ 'contributor.admin': true }); | |||
There was a problem hiding this comment.
TODO for me - revert this again and see if its working again
might have something to do with the domain-middleware that the CI's stopped for it
|
What's left with this PR |
negue
reviewed
Dec 10, 2023
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: sudo apt-get -y install libkrb5-dev |
There was a problem hiding this comment.
@SabreCat which program needed this dependency?
| @@ -41,11 +41,11 @@ describe('POST /challenges/:challengeId/flag', () => { | |||
| }); | |||
|
|
|||
| it('flags a challenge with a higher count when from an admin', async () => { | |||
| await user.update({ 'contributor.admin': true }); | |||
| const admin = await generateUser({ 'contributor.admin': true }); | |||
# Conflicts: # package-lock.json
# Conflicts: # package-lock.json # website/client/package-lock.json
# Conflicts: # package-lock.json # test/.eslintrc.js # website/client/package-lock.json # website/client/package.json # website/client/src/store/actions/user.js # website/client/src/store/index.js
# Conflicts: # package-lock.json # test/.eslintrc.js # website/client/package-lock.json # website/client/package.json # website/client/src/store/actions/user.js # website/client/src/store/index.js
…ved, viewbox stays) + SVGs in URLS wont be inlined
…cat/node-latest # Conflicts: # .eslintrc.js # package-lock.json # test/.eslintrc.js # website/client/src/assets/svg/experience.svg # website/client/src/assets/svg/gem-red.svg # website/client/src/assets/svg/gem.svg # website/client/src/assets/svg/hourglass-red.svg # website/client/src/assets/svg/hourglass.svg # website/client/src/assets/svg/streak.svg # website/client/src/assets/svg/warrior.svg # website/server/controllers/api-v3/chat.js
Also fixes an issue where process.env might be referenced before it's ready on the client
# Conflicts: # package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to upgrade NodeJS to latest version. Version 14 which Habitica currently uses is no longer supported.