Migrate from vue-cli-service to vite #15389
Conversation
.babelrc
Outdated
| } |
There was a problem hiding this comment.
This is a weird file change -- it's not like it was neatened up for lint exactly, as there's still no newline at end of file or the like. What's this for?
habitica-images
Outdated
There was a problem hiding this comment.
Likely to get outdated by the time this merges, and just as likely irrelevant to the project at hand
package.json
Outdated
| "mongoose": "^7.8.3", | ||
| "morgan": "^1.10.0", | ||
| "nconf": "^0.12.1", | ||
| "node-gcm": "^1.0.5", | ||
| "nodemon": "^2.0.20", | ||
| "nodemon": "^3.1.9", |
There was a problem hiding this comment.
With nodemon ops removed from dev server start and test, do we still need nodemon at all?
There was a problem hiding this comment.
(no action needed) huh I wonder when the refresh on this rogues' gallery is coming, maybe that should be a team agenda topic 😅
| @@ -858,12 +858,14 @@ import buyGemsModal from './payments/buyGemsModal.vue'; | |||
| import reportBug from '@/mixins/reportBug.js'; | |||
| import { worldStateMixin } from '@/mixins/worldState'; | |||
|
|
|||
| const DEBUG_ENABLED = process.env.DEBUG_ENABLED === 'true'; // eslint-disable-line no-process-env | |||
| const TIME_TRAVEL_ENABLED = process.env.TIME_TRAVEL_ENABLED === 'true'; // eslint-disable-line no-process-env | |||
| const DEBUG_ENABLED = import.meta.env.DEBUG_ENABLED === 'true'; // eslint-disable-line no-process-env | |||
There was a problem hiding this comment.
Does ESLint still gripe no-process-env if we're using import.meta.env instead?
There was a problem hiding this comment.
You're right, it shouldn't
website/client/vitest.config.js
Outdated
| environment: "jsdom", | ||
| }, | ||
| browser: { | ||
| enabled: true, |
There was a problem hiding this comment.
what is going on with the indents in here XD
gulp-nodemonand callnode --watchdirectlyuser-mainmodule inmain.js, which allows Vite to code split better between logged out/logged in, improving load times for the front page and other static pages.