Return IServiceCollection instead of void in ServiceCollectionExtensions
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of `void`
# Motivations
Returning the `IServiceCollection` allows for clean chaining of `Add..` calls, like so
```
services
.AddDiscordHost()
.AddCommandService()
.AddInteractionService()
```
# Modifications
- Return the `IServiceCollection` instead of `void`
- Add some commas to places in the comments, for grammar-sake
Twinki14
changed the title
IServiceCollectioninstead of void in ServiceCollectionExtensionsIServiceCollection instead of void in ServiceCollectionExtensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
Returning the
IServiceCollectionallows for clean chaining ofAdd..calls, which can be a popular pattern when configuring DI for many, like soModifications
IServiceCollectioninstead ofvoidExtra
Just wanted to thank you so much for this package, not just for the original implementation but also for maintaining it with the dotnet Host standards that continue to evolve