Add now playing panel #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit huge since it's introduct a lot of new element that we hard-coded befefore.
The
NowPlayingPanel(See Figma for reference)
I try to design it to make it like some popup on iOS's music app and make it as our style. Now it's usable but I still hard coded the database list since we still now have some 'seed' on the database.
Introduce
WorkingBeatmapandMusicPlayerAs its name
WorkingBeatmapare handle the twoBindableofBeatmapSetandDifficultyLevelMusicPlayerare handle the entire track playing system in-gameSince we have these two classes, now all element except the song slider are now use the new bindable instead of the hard-coded one.
The custom track store is working now
Now we can play the track from the game's folder. I currently set the folder name as
tracksso if you want to try you can put some track in the<gamefolder>/tracksto play with it. We will move tobeatmapsfolder to male it suitable with beatmap folder.TODO