Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore capitalization in filenames when extracting version #121

Closed
wants to merge 1 commit into from
Closed

ignore capitalization in filenames when extracting version #121

wants to merge 1 commit into from

Conversation

DeltaDaniel
Copy link
Contributor

@DeltaDaniel DeltaDaniel commented Jul 29, 2024 •
edited
Loading

hf-kklein
hf-kklein approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@hf-kklein hf-kklein left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ich fände den ansatz aus #123 schöner, da braucht es die zeile 150 nicht, aber das passt auch für mich. entscheide du :)
fixes #122

@hf-kklein hf-kklein linked an issue Jul 30, 2024 that may be closed by this pull request
Error in create_nachrichtenstruktur_tabelle(raw_lines): "String should match pattern '^\d{5}$' [type=string_pattern_mismatch, input_value='C0001', input_type=str]" #122
Closed
@DeltaDaniel DeltaDaniel removed a link to an issue Jul 30, 2024
Error in create_nachrichtenstruktur_tabelle(raw_lines): "String should match pattern '^\d{5}$' [type=string_pattern_mismatch, input_value='C0001', input_type=str]" #122
Closed
@DeltaDaniel
Copy link
Contributor Author

Closed with #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf-kklein hf-kklein hf-kklein approved these changes

@hf-krechan hf-krechan Awaiting requested review from hf-krechan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeltaDaniel @hf-kklein