fix: duplicate formats in input #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaDaniel
requested review from
hf-kklein and
hf-krechan
and removed request for
hf-kklein
hf-kklein
reviewed
Sep 3, 2024
| @@ -84,7 +84,8 @@ def main( | |||
| "💡 UTILMD is not available for format versions 2310 and above. Parse UTILMDS and UTILMDG instead." | |||
| ) | |||
| message_format.remove(EdifactFormat.UTILMD) | |||
| message_format.extend([EdifactFormat.UTILMDG, EdifactFormat.UTILMDS]) | |||
| message_format.extend([EdifactFormat.UTILMDG, EdifactFormat.UTILMDS, EdifactFormat.UTILMDW]) | |||
| message_format = list(set(message_format)) | |||
There was a problem hiding this comment.
verlierst du dadurch die sortierung? ws. nicht wichtig?
There was a problem hiding this comment.
Die Sortierung ist da nicht wichtig. Die Idee ist nur, dass im default Case (alle Formate inkl UTILMD und UTILMDS/UTILMDG) nichts doppelt ist. :)
hf-kklein
approved these changes
Sep 3, 2024
DeltaDaniel
deleted the
145-failure-in-fv2504-cannot-access-local-variable-latest_file-where-it-is-not-associated-with-a-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.