added csv output for Nachrichtenstrukturtabelle #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-krechan
approved these changes
Mar 13, 2024
src/migmose/__main__.py
Outdated
| @@ -45,6 +45,7 @@ def main(input_dir: Path, output_dir, message_format: list[EdifactFormat]) -> No | |||
| for m_format, file in dict_files.items(): | |||
| raw_lines = parse_raw_nachrichtenstrukturzeile(file) | |||
| nachrichtenstrukturtabelle = NachrichtenstrukturTabelle.init_raw_table(raw_lines) | |||
| nachrichtenstrukturtabelle.output_as_csv(m_format, output_dir) | |||
There was a problem hiding this comment.
Nur eine Frage des Geschmacks.
In dem dataframes von Pandas gibt es die Methode to_csv
Finde das auch sprechend wenn man schreibt nachrichtenstrukturtabelle.to_csv()
Ist aber nur Frage des Geschmackes
| lines: list[NachrichtenstrukturZeile] | ||
|
|
||
| @classmethod | ||
| def init_raw_table(cls, raw_lines: list[str]) -> "NachrichtenstrukturTabelle": |
There was a problem hiding this comment.
Vll hier auch analog zu unserer anderen klasse create_nachrichten...
Sehe am Handy gerade nicht mehr wie die Klasse heißt ^^'
| collected_lines.append(NachrichtenstrukturZeile.init_raw_lines(raw_line)) | ||
| return cls(lines=collected_lines) | ||
|
|
||
| def output_as_csv(self, message_type: EdifactFormat, output_dir: Path) -> None: |
There was a problem hiding this comment.
analog zu oben vll eher ein to_csv
Und der dictating redet von json ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.