Checking if there are more than one MIG docx files for a message_format #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
reviewed
Apr 12, 2024
src/migmose/parsing.py
Outdated
| @@ -37,6 +39,42 @@ def find_file_to_format(message_formats: list[EdifactFormat], input_dir: Path) - | |||
| raise click.Abort() | |||
|
|
|||
|
|
|||
| def get_latest_file(file_list): | |||
There was a problem hiding this comment.
Kannst du hier Type hints adden?
hf-krechan
approved these changes
Apr 15, 2024
| Tests to find multiple docx files with the same message_format. | ||
| """ | ||
| message_formats = [EdifactFormat.IFTSTA] | ||
| input_dir = Path("unittests/test_data/") |
There was a problem hiding this comment.
I am surprised that this path is working :D
Co-authored-by: kevin <68426071+hf-krechan@users.noreply.github.com>
Co-authored-by: kevin <68426071+hf-krechan@users.noreply.github.com>
hf-kklein
reviewed
Apr 15, 2024
| latest_date: datetime | None = None | ||
|
|
||
| for file_path in file_list: | ||
| date, path = extract_date(file_path) |
There was a problem hiding this comment.
hf-kklein
reviewed
Apr 15, 2024
| match = re.search(r"(\d{8})\.docx$", file_path.name) | ||
| if match: | ||
| # Return the date as a datetime object for comparison and the path for use | ||
| return datetime.strptime(match.group(1), "%Y%m%d"), file_path |
There was a problem hiding this comment.
das datetime hat keine zeitzone 😶 aber es ist egal, weil alle keine zeitzone haben :)
hf-krechan
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it takes latest file based on timestamp in .DOCX filename