Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navbar fragment and allow parent link #3206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CravateRouge
Copy link

Purpose

Enhancement:

  1. with this PR, "menu main" with children can also have a clickable link:
menus:
 main:
  - name: Services
   hasChildren: yes
   url: /services
  - name: Audit
   parent: Services
  url: /services/audit

Fix

  1. if "menu main" has no "url" it will default to href='' instead of href='/' (better to do logical testing with a $url="" in templating code)
  2. if only fragment provided as url: "#about" it is now associated to home page and not relative page, as intended before but the concatenating was forgot.

fragment as `url: "#about"` are now associated to home page and menu main with children can also have link
Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for academic-demo canceled.

Name Link
🔨 Latest commit 49f51cf
🔍 Latest deploy log https://app.netlify.com/sites/academic-demo/deploys/67e64e31ee1d0a0008f916d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant