Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] add overlay nav bar #1099

Merged
merged 8 commits into from
Oct 16, 2024
Merged

[Feat] add overlay nav bar #1099

merged 8 commits into from
Oct 16, 2024

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented Oct 3, 2024

Summary

Add overlay nav bar with disabled links for upcoming features

Screenshots

image

@BrettCleary BrettCleary marked this pull request as ready for review October 12, 2024 00:06
@BrettCleary BrettCleary added the PR: Ready-For-Review PR is ready to be reviewed by peers label Oct 12, 2024
Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jiyuu-jin jiyuu-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrettCleary BrettCleary added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels Oct 16, 2024
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the nav bar appears in the overlay when toggled. Currently it is just a placeholder and has no effects. It can be minimized and expanded. Looks great! I look forward to seeing future functionality!

image
image

@BrettCleary BrettCleary merged commit 0af346b into main Oct 16, 2024
11 checks passed
@BrettCleary BrettCleary deleted the feat/add_overlay_nav_bar branch October 16, 2024 19:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants