[Fix] Keep playstreak quests in sync #1111
Conversation
|
recheck |
|
All contributors have signed the CLA ✍️ ✅ |
| useEffect(() => { | ||
| const initSync = async () => { | ||
| try { | ||
| questPlayStreakSyncState.init({ |
There was a problem hiding this comment.
This is the only place it is used, so it is simpler to just call init right before. I initially explored adding it to StoreController, but the StoreController useEffect executes after this useEffect, which breaks keepProjectQuestsInSync
There was a problem hiding this comment.
how interesting, in my implementation of this in the store I used the StoreController approach
tbh I think this way is simpler and does the work too
There was a problem hiding this comment.
maybe we should move this into @hyperplay/quests-ui if it will be used on the store as well
| appQueryClient: queryClient | ||
| }) | ||
|
|
||
| await questPlayStreakSyncState.keepProjectQuestsInSync(appName) |
There was a problem hiding this comment.
clearAllTimers does not need to be called since the store and timers are destroyed when the overlay is closed, which is also when we should stop syncing play sessions
BrettCleary
added
PR: Ready-For-Test
|
@nyghtstalker Ready for a retest |
There was a problem hiding this comment.
- Confirmed that quests are moving to the claimable section when ready to be claimed
- Confirmed the claim button activates and is useable when quest is claimable
- Confirmed claim button works and reward can be claimed
- Confirmed that when the timer for the days completion is finished it will add and display the day to the count and be claimable if reaching the set day amount needed.
Summary
Brings in HyperPlay-Gaming/quests-ui#19
desktop client implementation of https://github.com/HyperPlay-Gaming/product-management/issues/657
Testing
https://app.qase.io/case/HC-378