Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] show gradient border on quest card selected #1119

Merged
merged 1 commit into from
Oct 22, 2024
Merged

[UI] show gradient border on quest card selected #1119

merged 1 commit into from
Oct 22, 2024

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented Oct 18, 2024 •
edited
Loading

Summary

closes https://github.com/HyperPlay-Gaming/product-management/issues/517

Testing

  1. Go to the quests page
  2. Click on a card
  3. Observe that the gradient border remains on that card even when not hovering it

@BrettCleary BrettCleary added the PR: Ready-For-Review PR is ready to be reviewed by peers label Oct 18, 2024
@BrettCleary BrettCleary self-assigned this Oct 18, 2024
@BrettCleary BrettCleary added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels Oct 21, 2024
nyghtstalker
nyghtstalker approved these changes Oct 21, 2024
View reviewed changes
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the hover border persists when selected. One line code change. So simple and sweet!

image

@BrettCleary BrettCleary merged commit f258700 into main Oct 22, 2024
11 checks passed
@BrettCleary BrettCleary deleted the ui/quest_card_selected branch October 22, 2024 05:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@eliobricenov eliobricenov eliobricenov approved these changes

@nyghtstalker nyghtstalker nyghtstalker approved these changes

@jiyuu-jin jiyuu-jin Awaiting requested review from jiyuu-jin

Assignees

@BrettCleary BrettCleary

Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrettCleary @flavioislima @eliobricenov @nyghtstalker