[Feat] Add better Compatibility layer support for Intel Macs #1253
+39
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more checks and improvements on the Compatibility Layer on macOS, Intel Macs in specific.
It will now check if it is a Intel Mac and default to Wine Crossover instead of GTPK since GPTK has terrible performance there.
How to Test
QASE Tests:
https://app.qase.io/project/HC?case=577&suite=183
https://app.qase.io/project/HC?case=578&suite=183
AI Summary
This pull request introduces support for distinguishing between Intel Macs and other Mac systems, and updates the logic accordingly in various parts of the codebase. Here are the most important changes:
Support for Intel Macs:
src/backend/constants.ts
: Added a new constantisIntelMac
to identify Intel-based Mac systems.src/backend/config.ts
: Updated the default configuration to accommodate Intel Macs by modifying theautoInstallDxvk
setting.src/frontend/screens/WineManager/index.tsx
: Added logic to handle Intel Macs differently in the Wine Manager UI settings.Code adjustments for Intel Mac compatibility:
src/backend/launcher.ts
: Updated thevalidWine
function to check for Intel Mac compatibility when determining if the system supports the Game Porting Toolkit.src/backend/utils/compatibility_layers.ts
: Modified thedownloadDefaultWine
function to use different Wine types based on whether the system is an Intel Mac.These changes ensure that the application can correctly identify and handle Intel-based Macs, allowing for more accurate configuration and compatibility checks.
Use the following Checklist if you have changed something on the Backend or Frontend: