-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] update MetaMask logo in the navbar and wallet connection modal #1255
[Chore] update MetaMask logo in the navbar and wallet connection modal #1255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. let's remove the height line before merging so the icon isn't slightly distorted
width: var(--space-md); | ||
height: var(--space-md); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will go from 16 to 14px at the 1300px breakpoint. Is that what you intended?
I think it's fine to just hardcode here or use --space-md-fixed
if you really want to use a value from the spacing system.
It also might be best to just set the width here. I think it is being slightly distorted by setting both since the svg aspect ratio isn't 1:1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This SVG MetaMask provided was a bit bigger than the one we have in terms of breath spacing/padding in the SVG area, so instead of using px, I changed to this var that I believe is from our DS no? I will change it to be --space-md-fixed
instead
…desktop-client into chore]-update-Metemask-logos-in-the-navbar-and-wallet-connection-modal
Changes
Technical Details
Changes
Use the following Checklist if you have changed something on the Backend or Frontend: