Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] update MetaMask logo in the navbar and wallet connection modal #1255

Conversation

biliesilva
Copy link
Contributor

Changes

  • Added MetaMask icon to the TopNavBar component
  • Integrated MetaMask icon from @hyperplay/ui component library
  • Icon is displayed when MetaMask browser sidebar links are enabled
  • Added styling for the MetaMask icon through the CSS module

Technical Details

  • Used Images.MetaMask component with appropriate styling
  • Icon visibility is controlled by showMetaMaskBrowserSidebarLinks context
  • Maintains existing badge notification functionality

Changes

image

image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@biliesilva biliesilva self-assigned this Mar 10, 2025
@biliesilva biliesilva added the PR: Ready-For-Review PR is ready to be reviewed by peers label Mar 10, 2025
Copy link
Collaborator

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. let's remove the height line before merging so the icon isn't slightly distorted

Comment on lines 78 to 79
width: var(--space-md);
height: var(--space-md);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will go from 16 to 14px at the 1300px breakpoint. Is that what you intended?

I think it's fine to just hardcode here or use --space-md-fixed if you really want to use a value from the spacing system.

It also might be best to just set the width here. I think it is being slightly distorted by setting both since the svg aspect ratio isn't 1:1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SVG MetaMask provided was a bit bigger than the one we have in terms of breath spacing/padding in the SVG area, so instead of using px, I changed to this var that I believe is from our DS no? I will change it to be --space-md-fixed instead

@biliesilva biliesilva merged commit a9dd8c4 into main Mar 11, 2025
11 checks passed
@biliesilva biliesilva deleted the chore]-update-Metemask-logos-in-the-navbar-and-wallet-connection-modal branch March 11, 2025 15:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Ready-For-Review PR is ready to be reviewed by peers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants