Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIx] Edge case where downloaded size is bigger than download size #1259

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

flavioislima
Copy link
Contributor

@flavioislima flavioislima commented Mar 13, 2025

This changes how we get the Download Size depending on the status, right now it uses download status for both install and extracting.

It also adds a safeguard to the Download Toast so it won't show a Downloaded size bigger than Total Download Size. Might not be needed but it is 'just in case' since our numbers might not be precise sometimes.

Current issue

image
image

Fixed

Gravar.a.tela_20250313_122432.mp4

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added PR: Ready-For-Review PR is ready to be reviewed by peers PR: WIP and removed PR: Ready-For-Review PR is ready to be reviewed by peers PR: WIP labels Mar 13, 2025
Copy link
Contributor

@biliesilva biliesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flavioislima flavioislima added Needs: UI/UX Design Priority: 3 - Medium Severity: 2 - Medium Moderate impact affecting a smaller subset of users or non-critical functionality. and removed PR: Ready-For-Review PR is ready to be reviewed by peers Needs: UI/UX Design labels Mar 20, 2025
@BrettCleary
Copy link
Collaborator

@flavioislima do you know why the amount download (2.1GB) is greater than the max to download (2.05GB) here?
image

@flavioislima
Copy link
Contributor Author

@flavioislima do you know why the amount download (2.1GB) is greater than the max to download (2.05GB) here?
image

The second part, smaller one, was using download size, while the downloaded, first part, was using install size.

You can see on the game page that the calculation is correct but here was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 3 - Medium Severity: 2 - Medium Moderate impact affecting a smaller subset of users or non-critical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants