Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Update MetaMask SDK #739

Merged
merged 4 commits into from
Feb 21, 2024
Merged

[Chore] Update MetaMask SDK #739

merged 4 commits into from
Feb 21, 2024

Conversation

BrettCleary
Copy link
Collaborator

Updates to @metamask/sdk 0.15.0 from 0.12.0

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@BrettCleary BrettCleary self-assigned this Feb 21, 2024
eliobricenov
eliobricenov approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@eliobricenov eliobricenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - we need linting

@awantoch awantoch mentioned this pull request Feb 21, 2024
Closed
nyghtstalker
nyghtstalker approved these changes Feb 21, 2024
View reviewed changes
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to connect MMM on my iPad to this PR on Windows.

iPad (8th gen) - Version: 16.6.1
MMM version 7.16.0 (1265)

@BrettCleary BrettCleary merged commit 341a727 into main Feb 21, 2024
13 of 16 checks passed
@BrettCleary BrettCleary deleted the chore/update_mm_sdk branch February 21, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobricenov eliobricenov eliobricenov approved these changes

@red-game-dev red-game-dev red-game-dev approved these changes

@nyghtstalker nyghtstalker nyghtstalker approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima

Assignees

@BrettCleary BrettCleary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrettCleary @eliobricenov @red-game-dev @nyghtstalker