Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add email subscription modal #763

Merged
merged 10 commits into from
Feb 28, 2024
Merged

feat: add email subscription modal #763

merged 10 commits into from
Feb 28, 2024

Conversation

eliobricenov
Copy link
Contributor

@eliobricenov eliobricenov commented Feb 26, 2024

<--- Put the description here --->

The modal will show after the user finishes the onboarding.

How to test:

  • import a MM wallet or connect MM mobile or wallet connect

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@eliobricenov eliobricenov changed the title refactor(constants): use production environment dev portal feat: add promo version to auth modal Feb 27, 2024
@eliobricenov eliobricenov changed the title feat: add promo version to auth modal feat: add email subscription modal Feb 27, 2024
@eliobricenov
Copy link
Contributor Author

A good portion of the component is similar to the AuthModal component but I wanted to decouple them so we have more control over it. By using a different electron partition we also make sure that we get the same layout even if the user logs in, which is not the case if we use the AuthModal.

@eliobricenov eliobricenov added PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA labels Feb 27, 2024
@nyghtstalker nyghtstalker self-requested a review February 27, 2024 23:13
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@BrettCleary
Copy link
Collaborator

works great for me

let's add an .env.example file with the LD flag

@BrettCleary
Copy link
Collaborator

Tested again and it works great for me!

@eliobricenov eliobricenov merged commit d42a4bb into main Feb 28, 2024
10 of 16 checks passed
@eliobricenov eliobricenov deleted the email-subscription branch February 28, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants