Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat-macOS] Add MSync Setting #795

Merged
merged 10 commits into from
Apr 3, 2024
Merged

[Feat-macOS] Add MSync Setting #795

merged 10 commits into from
Apr 3, 2024

Conversation

flavioislima
Copy link
Contributor

@flavioislima flavioislima commented Mar 13, 2024

Msync is a feature similar with Esync and Fsync on Linux and aim to improve the performance when using the compatibility layer for CPU intensive games.

Some games might get up to 100% performance, but others might not have any performance improvement as well.

More information about the patch: https://github.com/marzent/wine-msync

Since it won't cause any harm when enabled, it will be enabled by default.

Screenshot 2024-03-13 at 10 49 45

How to test

  • Setting should appear only on macOS.
  • When enabled, the settings should appear on the logs as true.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA Severity: 3 - Low Minimal impact, typically cosmetic issues or minor bugs affecting a few users. labels Mar 13, 2024
@flavioislima flavioislima self-assigned this Mar 13, 2024
Copy link
Collaborator

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@red-game-dev red-game-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@nyghtstalker
Copy link

I am seeing the option in Game Settings on Mac and it is not present on Windows. Toggling this option does reflect in the logs.

image image

@flavioislima flavioislima merged commit a0cf3c6 into main Apr 3, 2024
10 of 16 checks passed
@flavioislima flavioislima deleted the feat/mac_msync branch April 3, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA Severity: 3 - Low Minimal impact, typically cosmetic issues or minor bugs affecting a few users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants