Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech]: Update nile (#3525) #815

Merged
merged 6 commits into from
Apr 1, 2024
Merged

[Tech]: Update nile (#3525) #815

merged 6 commits into from
Apr 1, 2024

Conversation

flavioislima
Copy link
Contributor

@flavioislima flavioislima commented Mar 20, 2024 •
edited
Loading

Update Nile to fix issues with uninstalling amazon games

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima self-assigned this Mar 20, 2024
@flavioislima flavioislima added PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA labels Mar 20, 2024
@nyghtstalker
Copy link

nyghtstalker commented Apr 1, 2024 •
edited
Loading

  1. I believe there are two logins - one for the client and one for the site/store. Does the user need to login to both for the store to work?

image
image

  1. Clicking the Install button on an Amazon game opens the Windows save instead of downloading through the client

image

  1. Clicking the Play button

image

  1. Do they need the app installed to play games? I don't see how we can download games from HP.

image

  1. The download rate is not displayed correctly and the ETA does not match.

image

nyghtstalker
nyghtstalker approved these changes Apr 1, 2024
View reviewed changes
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am now seeing the download rate displayed correctly.

@flavioislima flavioislima merged commit fdb61fd into main Apr 1, 2024
10 of 16 checks passed
@flavioislima flavioislima deleted the fix/amazon_fixes branch April 1, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobricenov eliobricenov eliobricenov approved these changes

@red-game-dev red-game-dev red-game-dev approved these changes

@nyghtstalker nyghtstalker nyghtstalker approved these changes

@BrettCleary BrettCleary Awaiting requested review from BrettCleary

Assignees

@flavioislima flavioislima

Labels
PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flavioislima @nyghtstalker @eliobricenov @red-game-dev @imLinguin