Skip to content

feat(Partner Center Sell): adding cbr options for iam registration #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2025
Merged

feat(Partner Center Sell): adding cbr options for iam registration #403

merged 4 commits into from
Sep 12, 2025

Conversation

HarasztiaPeter
Copy link
Contributor

@HarasztiaPeter HarasztiaPeter commented Sep 2, 2025 •
edited
Loading

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@HarasztiaPeter
feat(partner center sell): adding cbr options for iam registration
a4e97a0 
Signed-off-by: Peter Harasztia <peter.harasztia@ibm.com>
@HarasztiaPeter
feat(partner center sell): fix integratino tests
10cd631 
Signed-off-by: Peter Harasztia <peter.harasztia@ibm.com>
@HarasztiaPeter
feat(partner center sell): fix example tests
1d0e3b9 
Signed-off-by: Peter Harasztia <peter.harasztia@ibm.com>
@HarasztiaPeter
Copy link
Contributor Author

HarasztiaPeter commented Sep 4, 2025 •
edited
Loading

Example tests:
Screenshot 2025-09-04 at 14 26 14

@HarasztiaPeter HarasztiaPeter marked this pull request as ready for review September 4, 2025 12:33
@HarasztiaPeter
Copy link
Contributor Author

Integration:
Screenshot 2025-09-04 at 14 48 57

@pyrooka pyrooka changed the title feat(partner center sell): adding cbr options for iam registration feat(Partner Center Sell): adding cbr options for iam registration Sep 10, 2025
pyrooka
pyrooka requested changes Sep 10, 2025
View reviewed changes
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things to change, otherwise it looks good. I'll approve once these are addressed.

partnercentersellv1/partner_center_sell_v1_examples_test.go
Comment on lines 591 to 593
// begin-update_iam_registration

time.Sleep(25 * time.Second)
iamServiceRegistrationPatchModel := &partnercentersellv1.IamServiceRegistrationPatch{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comment here:

  1. Let's surround the operation tags (begin-...) with blank lines
  2. The sleep doesn't belong to the actual example, it should be outside of the example block
  3. Do we really need that much pause here? Just asking because I don't see sleeps in the integration tests. If the answer is yes, please make it more noticable - just in case someone else wants to run these tests. Something like fmt.Println("Waiting for 25 seconds...") should be sufficient.
Suggested change
// begin-update_iam_registration
time.Sleep(25 * time.Second)
iamServiceRegistrationPatchModel := &partnercentersellv1.IamServiceRegistrationPatch{}
time.Sleep(25 * time.Second)
// begin-update_iam_registration
iamServiceRegistrationPatchModel := &partnercentersellv1.IamServiceRegistrationPatch{}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For number 3:
The Read-Your-Writes Consistency is not really working downstream had to add sleep so it will work.
For more detail you can find my post in the iam-issues channel in slack.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks for the explanation!

@HarasztiaPeter
feat(partner center sell): refactored based on comments
1f51e30 
Signed-off-by: Peter Harasztia <peter.harasztia@ibm.com>
pyrooka
pyrooka approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HarasztiaPeter
Copy link
Contributor Author

@pyrooka Hello!
Sorry to disturb you, but what should be the next step?
I see one test failing but in a part that was not touched by me.
What should be my next step?

@pyrooka
Copy link
Member

pyrooka commented Sep 11, 2025

@HarasztiaPeter Turned out it was just a glitch. After re-running all the builds, everything is clean, so this PR is good to go. One question though: are you planning to open similar PRs in the other repositories or it's only for the Go SDK and I can merge it right now?

@HarasztiaPeter
Copy link
Contributor Author

@pyrooka You can merge it. We only need this SDK for our terraform provider.

@pyrooka pyrooka merged commit e93483c into main Sep 12, 2025
19 of 22 checks passed
@pyrooka pyrooka deleted the cbr-for-iam-service-registration--parnercentersellv1 branch September 12, 2025 08:47
ibm-devx-sdk pushed a commit that referenced this pull request Sep 12, 2025
@semantic-release-bot
chore(release): 0.87.0 release notes [skip ci]
e71464d 
# [0.87.0](v0.86.1...v0.87.0) (2025-09-12)

### Features

* **Partner Center Sell:** adding cbr options for iam registration ([#403](#403)) ([e93483c](e93483c))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.87.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrooka pyrooka pyrooka approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarasztiaPeter @pyrooka @ibm-devx-sdk