Skip to content

Commit

Permalink
draft PR for NFTpro plugin-nft-collections
Browse files Browse the repository at this point in the history
  • Loading branch information
IkigaiLabsETH committed Dec 21, 2024
1 parent d23e90c commit f9db542
Showing 1 changed file with 33 additions and 57 deletions.
90 changes: 33 additions & 57 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,84 +2,60 @@

# Relates to:

<!-- LINK TO ISSUE OR TICKET -->

<!-- This risks section is to be filled out before final review and merge. -->
NFTpro brand deployment for plugin-nft-collections

# Risks

<!--
Low, medium, large. List what kind of risks, and what could be effected.
-->
Low - This is a brand deployment that has been tested on the NFTpro environment.

- No changes to core plugin functionality
- Only brand-specific configurations and customizations
- Tested with Reservoir API integration

# Background

## What does this PR do?

Deploys NFTpro brand configurations and customizations to the develop branch of the NFT Collections Plugin. This plugin provides NFT collection data, market stats, and trading capabilities through Reservoir API integration.

## What kind of change is this?

<!--
Bug fixes (non-breaking change which fixes an issue)
Improvements (misc. changes to existing features)
Features (non-breaking change which adds functionality)
Updates (new versions of included code)
-->
Updates (brand-specific configurations)

<!-- This "Why" section is most relevant if there is no linked issue explaining why. If there is a related issue it might make sense to skip this why section. -->
<!--
## Why are we doing this? Any context or related work?
-->
- Brand-specific UI/UX customizations
- Configuration updates for NFTpro environment
- No core functionality changes to the plugin features

# Documentation changes needed?

<!--
My changes do not require a change to the project documentation.
My changes require a change to the project documentation.
If a docs change is needed: I have updated the documentation accordingly.
-->

<!-- Please show how you tested the PR. This will really help if the PR needs to be retested, and probably help the PR get merged quicker. -->
My changes do not require a change to the project documentation as they are brand-specific configurations that don't affect the core plugin functionality.

# Testing

## Where should a reviewer start?

## Detailed testing steps
1. Review brand configuration files for NFTpro customizations
2. Check the deployment settings in the following areas:
- Collection data and market stats integration
- Floor prices and volume tracking setup
- Brand-specific UI components
- API configuration for the NFTpro environment

<!--
None, automated tests are fine.
-->

<!--
- As [anon/admin], go to [link]
  - [do action]
  - verify [result]
-->

<!-- If there is a UI change, please include before and after screenshots or videos. This will speed up PRs being merged. It is extra nice to annotate screenshots with arrows or boxes pointing out the differences. -->
<!--
## Screenshots
### Before
### After
-->

<!-- If there is anything about the deploy, please make a note. -->
<!--
# Deploy Notes
-->
## Detailed testing steps

<!--  Copy and paste commandline output. -->
<!--
## Database changes
-->
- Verify brand configuration files are correctly structured
- Ensure all brand-specific assets and UI components are included
- Test Reservoir API integration with NFTpro configuration
- Verify collection data fetching and display
- Check market stats functionality with brand styling
- Confirm no conflicts with existing brand configurations
- Test floor price and volume tracking with NFTpro theming

<!--  If there is something more than the automated steps, please specifiy deploy instructions. -->
<!--
## Deployment instructions
-->
# Deploy Notes

<!-- If you are on Discord, please join https://discord.gg/ai16z and state your Discord username here for contribute role and join us in #development-feed -->
<!--
## Discord username
Brand deployment for NFTpro has been tested in the brand-specific environment with:

-->
- Verified Reservoir API integration
- Tested collection data fetching
- Confirmed market stats display
- Validated brand-specific UI components

0 comments on commit f9db542

Please sign in to comment.