Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove easy SystemTask dependencies in BLE services #1689

Merged
merged 6 commits into from
Mar 19, 2023
Merged

Remove easy SystemTask dependencies in BLE services #1689

merged 6 commits into from
Mar 19, 2023
+31 −55

Conversation

Riksu9000
Copy link
Contributor

No description provided.

@Riksu9000 Riksu9000 added the maintenance Background work label Mar 15, 2023
@Riksu9000 Riksu9000 requested a review from a team March 15, 2023 08:51
@github-actions
Copy link

github-actions bot commented Mar 15, 2023 •
edited
Loading

Build size and comparison to main:

Section Size Difference
text 406472B -32B
data 940B 0B
bss 53560B -8B

NeroBurner
NeroBurner approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one unrelated note, otherwise looking good

FintasticMan
FintasticMan approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@FintasticMan FintasticMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Riksu9000 Riksu9000 merged commit 0a4f015 into InfiniTimeOrg:main Mar 19, 2023
@Riksu9000 Riksu9000 deleted the nimblecontroller-cleanup branch March 19, 2023 10:41
@JF002 JF002 added this to the 1.12.0 milestone Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeroBurner NeroBurner NeroBurner approved these changes

@FintasticMan FintasticMan FintasticMan approved these changes

Assignees
No one assigned
Labels
maintenance Background work
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Riksu9000 @NeroBurner @FintasticMan @JF002