Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing character for navigation font #2005

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

kieranc
Copy link
Contributor

@kieranc kieranc commented Feb 6, 2024

Whichever idiot touched the navigation app UI last managed to think about imperial and metric distance units and the characters necessary to represent them, but not that some distances might need the . (period/full stop) character.

The result is that currently, 3.1km displays as 31km, and is somewhat confusing.
I am the idiot. I forgot the . character. This PR fixes my mistake.

Copy link

github-actions bot commented Feb 6, 2024

Build size and comparison to main:

Section Size Difference
text 373108B 0B
data 940B 0B
bss 63516B 0B

Copy link
Member

@FintasticMan FintasticMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of extra commits from the last PR, but that doesn't matter if we squash merge.

@FintasticMan FintasticMan merged commit 44be356 into InfiniTimeOrg:main Feb 7, 2024
@FintasticMan FintasticMan added this to the 1.15.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants