-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: Header redesign #2032
README: Header redesign #2032
Conversation
Looks very nice imo 👏 |
Glad you like it! I did it in Adobe Photoshop by taking several screenshots from InfiniSim ;) and then merging each screen with a representation of the physical watch that was used in InfiniLink. Then I positioned everything, added the screen that's stacked on the others, and lastly, I added a circle with a Gaussian blur behind everything for the shadow effect. |
This is beautiful. Great work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really pretty :)
I like the way it looks, but I do find it a bit strange that the yellow in the picture is darker than it "should" be. |
Not sure if it really matters, but do you mean the yellow in the InfiniTime logo? |
Yeah, the yellow in the InfiniTime logo is darker than other places we use it. It looks like the colours are inverted actually, so I can see how it happened. I feel like maybe you could use the picture we use for the recovery firmware, that's on a black background. |
@liamcharger I think you accidentally pushed an unrelated change to this branch. We recommend using separate branches for each PR, and not using main, to prevent this happening by accident. |
Oops, that was an accident...thought I was on a different branch. |
@FintasticMan do you know where I can get an image resource of the recovery firmware picture? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll do that. |
@FintasticMan @mark9064 @JF002 all done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! If you update it to the latest main I'll merge it.
Great! The branch is already up to date, though. |
Ah, sorry, I had rebase merge selected rather than squash merge. |
* Reformat README.md * Update README.md * Add files via upload * Add files via upload * Add new README.md header image * Remove unnecessary <br> tag * Scale watchface logo down; add downloads badge * Remove unnecessary <br> tag * Add <br> tag to maintain spacing consistency * Remove incorrect link * Add watchface logo with dark logo * Replace logo image with dark version * Add files via upload * Add header image * Fix row spacing in header image * Remove unnecessary <br> tag * Add corner radius to header image * Add files via upload * Update image background * Add reference to InfiniTimeExplorer * Remove unnecessary image * Remove unnecessary image * Remove unnecessary images * Rename watchface_collage_no_shadow.png to watchface_collage.png * Update header image URL * Remove unnecessary <br> tag * SPI transaction hooks * Remove task to notify * Refactor display WriteToRam * Use functional abstraction for hooks * Refactor lambdas * Avoid storing lambda * Rename to pre-transaction hook * Use FreeRTOS delay instead of spinning the CPU * Apply display driver datasheet delays * Move includes back * Include task header (Fixes sim) * Make chime vibrate twice * Remove commit from main * README: improve wording * Add bootloader to DeviceInformationService.cpp * Add bootloader to DeviceInformationService.h * Revert "Add bootloader to DeviceInformationService.h" This reverts commit f3f0fd5. * Revert "Add bootloader to DeviceInformationService.cpp" This reverts commit 35570ed. * Delete doc/logo/watchface_collage.png * Add files via upload * Delete doc/logo/watchface_collage.png * Add files via upload * Replace collage with correct image --------- Co-authored-by: mark9064 <30447455+mark9064@users.noreply.github.com>
* Reformat README.md * Update README.md * Add files via upload * Add files via upload * Add new README.md header image * Remove unnecessary <br> tag * Scale watchface logo down; add downloads badge * Remove unnecessary <br> tag * Add <br> tag to maintain spacing consistency * Remove incorrect link * Add watchface logo with dark logo * Replace logo image with dark version * Add files via upload * Add header image * Fix row spacing in header image * Remove unnecessary <br> tag * Add corner radius to header image * Add files via upload * Update image background * Add reference to InfiniTimeExplorer * Remove unnecessary image * Remove unnecessary image * Remove unnecessary images * Rename watchface_collage_no_shadow.png to watchface_collage.png * Update header image URL * Remove unnecessary <br> tag * SPI transaction hooks * Remove task to notify * Refactor display WriteToRam * Use functional abstraction for hooks * Refactor lambdas * Avoid storing lambda * Rename to pre-transaction hook * Use FreeRTOS delay instead of spinning the CPU * Apply display driver datasheet delays * Move includes back * Include task header (Fixes sim) * Make chime vibrate twice * Remove commit from main * README: improve wording * Add bootloader to DeviceInformationService.cpp * Add bootloader to DeviceInformationService.h * Revert "Add bootloader to DeviceInformationService.h" This reverts commit f3f0fd5. * Revert "Add bootloader to DeviceInformationService.cpp" This reverts commit 35570ed. * Delete doc/logo/watchface_collage.png * Add files via upload * Delete doc/logo/watchface_collage.png * Add files via upload * Replace collage with correct image --------- Co-authored-by: mark9064 <30447455+mark9064@users.noreply.github.com>
This PR enhances the visual appeal of the main README.md header with a restyled header design. Open to feedback and suggestions for further improvements!
Additionally, in the README body, I've included a reference to InfiniTimeExplorer since its existence is not widely known.
Please refer to my InfiniTime fork for a preview of the changes.