Trans watchface #2201
Trans watchface #2201
Conversation
|
Build size and comparison to main:
|
|
Love it! 🏳️⚧️😁 You are a very cool person, I'm going to be using this for a while! Edit to add: I hope you find $20 on the ground or something similar fortunate and nice happens to you!
|
|
Thanks for the quick feedback! I've implemented those changes, hopefully everything's good now |
|
All looks good to me! You couldn't have made review easier :) I haven't had the chance to test on hardware yet and am away for now, but I should be able to test within a couple weeks time |
|
I have been using this daily, and I really like it, but I have a few small suggestions: I adore the "You have mail." for notifications, but I dislike that it overlaps so severely with the battery percentage:
I think it might look better to have "mail." on its own line below, and move "You have" up a little bit so they're both centered vertically in the blue stripe. (The 90's kid in me really wants it to read "You've got mail," like AOL, but that's not a request for a change, just a nostalgic observation) My other suggestion is to name the watch face more specifically as "Trans Flag" instead of just "Trans."
Like I said, very very small suggestions. The other 99% of this watchface is grand! |
|
I definitely agree with the notification and the name. Fortunately, these are just one-line fixes so it's not that hard to change. |
…m "Trans" to "Trans Flag"
|
Good spot, I'll fix that |
|
You are an incredibly awesome and speedy person! Thanks for implementing my suggestions, and so fast! I'll keep testing this daily for a while and let you know if I come across anything else 😁 |
|
Hello again, I noticed another little thing after using this watch face for a while. Usually I keep my watch in 24 hour time, but I had reason to use 12 hour time today, and I noticed that both AM and PM show up as "M." (I manually set the watch to 2am to get the second picture, I didn't stay up late 😜)
|
|
I think what's happening here is that the font used for the time doesn't have all the alphabet, if I change the font to something else it seems to work fine: |
|
That's an elegant fix! I like it! Unfortunately, in addition to praise I also come bearing news of a new bug: it is displaying 24-hour time when I have 12-hour time enabled.
|
|
Aah, well at least that's an easy fix; it should all be working now |
|
could you update to/rebase onto the latest |
|
Yup, should be all good now |
|
Seems like this would wait for side loading. It may not fit the vision of "Only a minimal feature set in the flashed firmware". But, no biggy. |
I dont understand why this watchface was added to the 1.16.0 milestone so quickly over the various other watchface PRs that have been sitting around for quite a long time? |
|
Mainly because it doesn't depend on any other PRs and was easy to review Things get added to the milestone when we want to target including them this cycle. If a PR depends on lots of other refactoring for example, or has outstanding bugs that are taking time to resolve, then it usually won't be queued up for the next cycle until it's ready. InfiniTime generally lacks reviewers though, so what gets queued and what doesn't depends on whether someone's had time to look at it properly Edit: also you're totally welcome to help with review or express support/interest in PRs in the comments, it helps with prioritising review |
|
Yeah, that makes sense - I've renamed all the WatchFaceTrans to WatchFaceTransFlag |
|
Wait why don't we use this as a general LGBTQ flag watchface? It would make the most sense to add all of the flags into the design if we already have the one. You can choose which one you want the same way you change the colors on the Infinineat watchface. |
|
I really like that idea! I've implemented four pride flags, (the classic rainbow, the existing trans flag design, the bi flag and the lesbian flag), and the switching seems to work fine |
|
|
|
Oops |
Adds a new watch face with the trans flag as a background
Features
Images