Center text on timer button #2229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
tituscmd
force-pushed
the
timer_centered
branch
from
b93c2e7 to
6f9caa4
Compare
mark9064
added
enhancement
tituscmd
force-pushed
the
timer_centered
branch
from
7ea3030 to
d033f19
Compare
mark9064
reviewed
Feb 14, 2025
| txtPlayPause = lv_label_create(lv_scr_act(), nullptr); | ||
| lv_obj_align(txtPlayPause, btnPlayPause, LV_ALIGN_CENTER, 0, 0); | ||
| txtPlayPause = lv_label_create(btnPlayPause, nullptr); | ||
| // lv_obj_align(txtPlayPause, btnPlayPause, LV_ALIGN_CENTER, 0, 0); |
There was a problem hiding this comment.
Since it's now auto aligned I think this line can be fully deleted. Maybe if you would like to point out the alignment a comment above the label creation would work nicely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everybody!
This PR is made to center the "Start"/"Pause" text on the button in the timer app. The previous implementation created the text object and aligned it to the button object, this implementation creates the text object with a pointer to the button object and thus makes it centered at all times!
Here's a screenshot of InfiniEmu running it:
