-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds vibration strength settings #2231
Conversation
This reverts commit 950ac01.
don't have the space for the fonts lmao
Add segment option
Fast-forward to InfiniTime main
Build checks have not completed. Possible reasons for this are:
|
Rebase to fix ci, #2224 is merged now |
e54cf2d
to
107e0cc
Compare
Apparently there's a button to rebase branches, TIL. Rebased it for you ^^ |
Casio weather
It looks like you've merged in some other things like weather on the casio watchface to this branch. What I'd suggest is making a local branch that has all the changes you want on your watch merged into it, and then keeping this branch to just the vibration feature, as it's not really possible to review or merge a specific feature when you have multiple features all in one branch |
Oh yeah I really messed up the history of this one lol, not sure how that happened. Must have rebased off the wrong branch somewhere along the way. I'll make a new branch and pr for just the vibration stuff. |
If you fancy rebasing that would also work (then force push after). |
Re-created as #2235 |
This pr adds 2 new settings, one for notification and one for the hour/half hour chime vibration strengh.
Also previews the selected strength when you exit the menu. I'd prefer for this to happen when you select an option, but I couldn't figure out how to do that.
The only way I could think of how to get this to work was by changing the time the vibration motor is activated. With the values I gave them, there's a pretty pronounced difference between the lowest and highest setting, without it starting to feel like a long vibration.
Could use some suggestions on icons to use for the settings as I haven't added any yet.