Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds vibration strength settings #2231

Closed
wants to merge 44 commits into from

Conversation

Ghoelian
Copy link

@Ghoelian Ghoelian commented Jan 21, 2025

This pr adds 2 new settings, one for notification and one for the hour/half hour chime vibration strengh.

Also previews the selected strength when you exit the menu. I'd prefer for this to happen when you select an option, but I couldn't figure out how to do that.

The only way I could think of how to get this to work was by changing the time the vibration motor is activated. With the values I gave them, there's a pretty pronounced difference between the lowest and highest setting, without it starting to feel like a long vibration.

Could use some suggestions on icons to use for the settings as I haven't added any yet.

Ghoelian added 30 commits August 3, 2024 17:40
don't have the space for the fonts lmao
Copy link

github-actions bot commented Jan 21, 2025

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed

@mark9064 mark9064 added the enhancement Enhancement to an existing app/feature label Jan 23, 2025
@mark9064
Copy link
Member

Rebase to fix ci, #2224 is merged now

@mark9064
Copy link
Member

Apparently there's a button to rebase branches, TIL. Rebased it for you ^^

@mark9064
Copy link
Member

It looks like you've merged in some other things like weather on the casio watchface to this branch. What I'd suggest is making a local branch that has all the changes you want on your watch merged into it, and then keeping this branch to just the vibration feature, as it's not really possible to review or merge a specific feature when you have multiple features all in one branch

@Ghoelian
Copy link
Author

Oh yeah I really messed up the history of this one lol, not sure how that happened. Must have rebased off the wrong branch somewhere along the way.

I'll make a new branch and pr for just the vibration stuff.

@mark9064
Copy link
Member

If you fancy rebasing that would also work (then force push after). --rebase-merges is your friend there

@Ghoelian
Copy link
Author

Re-created as #2235

@Ghoelian Ghoelian closed this Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing app/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants