-
-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background color to progress bar when flashing firmware #2237
base: main
Are you sure you want to change the base?
Add background color to progress bar when flashing firmware #2237
Conversation
Build size and comparison to main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested on HW, but looks good from the screenshot :)
Just a note about the space between the value and percentage sign. A space there is the correct way of writing it. 🙂 I think it should be formatted the correct way. I can understand that sometimes it happens that the correct way doesn't feel right. We tend to expect what we're conditioned to. I've had the same experience. Though, it's just a matter of getting used to it, i.e. reconditioning. So rather than doing what subjectively feels right I think there's value to following objectively correct and commonly agreed conventions. 🙂 A lack there of will have negative effects regardless whether it's in a software project or in a book, as we adopt by reading and using language. So whenever something is incorrect, it spreads. Other than that, I very much welcome the progress bar improvement. 😊 |
"However, the International System of Units and ISO 31-0 standard prescribe a space between the number and percent sign,[8][9][10] in line with the general practice of using a non-breaking space between a numerical value and its corresponding unit of measurement." Let's go for this then, shall we? |
I think without the space is better. Wikipedia is quite clear: InfiniTime is not a technical document, but instead a user interface. Therefore I think following general English style and precedent makes sense. If it were a technical report then I would agree that recognising a standard such as ISO would be sensible (and if I were typsetting with LateX I would by using |
This PR adds a background color to the progress bar when updating firmware.
It also removes the space between the value and the "%", since I feel like that's more commonly used and, in my opinion, looks better. Feel free to give your opinion on that, though!
Here's a pic of how it looks like on device:

(Hint: To see it in action, you’ll first need to flash the firmware. Then, flash any other firmware, as the firmware update screen is displayed by the firmware currently on the device.)