Improved StopWatch UI (iOS-inspired) #2251
Open
+71
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The lap time displays the duration of the lap instead of the time at which the lap button was pressed. 2. The current lap's time that has elapsed should already be displayed for "running laps" that haven't been stopped yet.
|
Build size and comparison to main:
|
mark9064
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lap times used to be cumulative, instead of starting at 0 for each lap (which is more useful imo). I changed lap time behaviour so that 1) lap 1 starts counting as the stopwatch is started 2) final lap times are now the duration of the lap instead of the end point in "absolute time". I also changed the UI to be more clear: "#1" became "Lap 1". I moved the millisecond indicator to the top of the colon to make space for a third lap. This way the UI provides more information than before (2 laps only) without feeling crowded.