Skip to content

make array Hermitian before calling complex-to-real FFT #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented May 12, 2025

In this PR, input array is made Hermitian before calling complex-to-real FFT.

Input array should be Hermitian before calling complex-to-real FFT otherwise the behavior is undefined. Although it is user responsibility to validate this feature, NumPy and CuPy internally make the input array Hermitian. So, it is done in dpnp for consistency.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this May 12, 2025
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2444/index.html

@coveralls
Copy link
Collaborator

coveralls commented May 12, 2025

Coverage Status

coverage: 71.711% (+0.02%) from 71.692%
when pulling b209de7 on make-Hermitian
into 282016e on master.

Copy link
Contributor

github-actions bot commented May 12, 2025

Array API standard conformance tests for dpnp=0.18.0dev2=py312he4f9c94_20 ran successfully.
Passed: 1229
Failed: 0
Skipped: 9

@vtavana vtavana added this to the 0.18.0 release milestone May 13, 2025
@vtavana vtavana marked this pull request as ready for review May 13, 2025 01:44
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants