[MOB-11904] consent logging triggered in complete user login #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantk91
changed the title
added 3 commits
August 21, 2025 16:54
Ayyanchira
reviewed
Aug 25, 2025
Comment on lines
623
to
656
| IterableHelper.SuccessHandler wrappedSuccessHandler = null; | ||
| if (_setUserSuccessCallbackHandler != null) { | ||
| final IterableHelper.SuccessHandler originalSuccessHandler = _setUserSuccessCallbackHandler; | ||
| wrappedSuccessHandler = new IterableHelper.SuccessHandler() { | ||
| @Override | ||
| public void onSuccess(@NonNull JSONObject data) { | ||
| // Track consent now that user has been created/updated via device registration | ||
| if (config.enableUnknownUserActivation && getVisitorUsageTracked() && config.identityResolution.getReplayOnVisitorToKnown()) { | ||
| if (!getConsentLogged()) { | ||
| boolean isUserKnown = (_userIdUnknown == null); | ||
| trackConsentForUser(_email, _userId, isUserKnown); | ||
| setConsentLogged(true); | ||
| } | ||
| } | ||
|
|
||
| // Call the original success handler | ||
| originalSuccessHandler.onSuccess(data); | ||
| } | ||
| }; | ||
| } else if (config.enableUnknownUserActivation && getVisitorUsageTracked() && config.identityResolution.getReplayOnVisitorToKnown()) { | ||
| // Even if there's no original success handler, we still need to track consent | ||
| wrappedSuccessHandler = new IterableHelper.SuccessHandler() { | ||
| @Override | ||
| public void onSuccess(@NonNull JSONObject data) { | ||
| if (!getConsentLogged()) { | ||
| boolean isUserKnown = (_userIdUnknown == null); | ||
| trackConsentForUser(_email, _userId, isUserKnown); | ||
| setConsentLogged(true); | ||
| } | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| apiClient.registerDeviceToken(email, userId, authToken, applicationName, deviceToken, dataFields, deviceAttributes, wrappedSuccessHandler, _setUserFailureCallbackHandler); |
There was a problem hiding this comment.
Loved the idea of wrapping a success handler. It can be further optimized by not having repeated block of onSuccess.
added 3 commits
August 27, 2025 14:20
Ayyanchira
reviewed
Aug 27, 2025
Comment on lines
+628
to
643
| private IterableHelper.SuccessHandler getSuccessHandler() { | ||
| IterableHelper.SuccessHandler wrappedSuccessHandler = null; | ||
| if (_setUserSuccessCallbackHandler != null || (config.enableUnknownUserActivation && getVisitorUsageTracked() && config.identityResolution.getReplayOnVisitorToKnown())) { | ||
| final IterableHelper.SuccessHandler originalSuccessHandler = _setUserSuccessCallbackHandler; | ||
| wrappedSuccessHandler = data -> { | ||
| // Track consent now that user has been created/updated via device registration | ||
| trackConsentOnDeviceRegistration(); | ||
|
|
||
| // Call the original success handler if it exists | ||
| if (originalSuccessHandler != null) { | ||
| originalSuccessHandler.onSuccess(data); | ||
| } | ||
| }; | ||
| } | ||
| return wrappedSuccessHandler; | ||
| } |
Ayyanchira
reviewed
Aug 27, 2025
| if (_applicationContext == null) { | ||
| return false; | ||
| } | ||
| SharedPreferences sharedPreferences = _applicationContext.getSharedPreferences(IterableConstants.SHARED_PREFS_FILE, Context.MODE_PRIVATE); |
There was a problem hiding this comment.
Good that we are persisting it now
Ayyanchira
reviewed
Aug 27, 2025
| if (!getConsentLogged()) { | ||
| boolean isUserKnown = (_userIdUnknown == null); | ||
| trackConsentForUser(_email, _userId, isUserKnown); | ||
| setConsentLogged(true); |
There was a problem hiding this comment.
I saw that a user can be created even with device registration failing due to no device ID generation.
Do we not want consent to be tracked in that case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description