Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: msw 설치, 세팅 & 리뷰, 여행기에 적용 #10

Merged
merged 17 commits into from
Apr 24, 2024

Conversation

dev-yun
Copy link
Contributor

@dev-yun dev-yun commented Apr 14, 2024

Reference 📚


Motivation 🤔

  • BE없이 기능 개발 + test code + storybook을 위해 msw 도입

Key Chains 🔑

  • MockProvider 코드를 통해 browser 환경에서 mockServiceWorker에서 제공하는 service worker 등록
  • handler를 통해 place, review, travel story get api 추가
    • query params, params등을 사용하는 방법 공부 필요
    • 아직 hot reload가 안되는 것 같음 (handler에서 response값을 변경해도 바로 반영되지 않음 cache되나?)

To Reviewers 🙏

2024-04-14.11.30.35.mov

@dev-yun dev-yun marked this pull request as ready for review April 14, 2024 14:33
@dev-yun dev-yun force-pushed the feat/main_card_msw branch from a55d46c to 0a3b4f8 Compare April 14, 2024 14:59
dev-yun added 16 commits April 23, 2024 00:12
- / page에서 home으로 redirect 시키는 코드 추가(locale 때문에 / page를 home으로 하지 않음
- heart, start, comment Icon 추가
- global SUIT font 적용, 기본 noto next font 제거
- w-30, h-30이 안됐던 이유 -> tailwind에 w-30, h30이 정이되지 않았음..
- pathname 논의 필요
@dev-yun dev-yun force-pushed the feat/main_card_msw branch from 0a3b4f8 to efc1cc7 Compare April 22, 2024 15:30
Copy link
Contributor

@dgd03146 dgd03146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 완료했습니다!

@dgd03146 dgd03146 merged commit fe0c07d into develop Apr 24, 2024
@dgd03146 dgd03146 deleted the feat/main_card_msw branch April 24, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants