-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add images to team section #37
Conversation
@karandevtyagi done! |
@eldraco19 Toggle to mobile devices in your dev tools and look at the extra spaces in complete website and remove them.Plus add credit to yourself in footer or add github repo link so that you can show this in future to someone or in resume if required. |
@karandevtyagi on Desktop it looks fine, on mobile I tried to reduce as much as I can without affecting other components. |
Lines 525 to 536 in ec2f74e
Colorlib -> JIITODC? WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
Co-Authored-By: Pranshu Srivastava <rexagod@gmail.com>
Co-Authored-By: Pranshu Srivastava <rexagod@gmail.com>
Co-Authored-By: Pranshu Srivastava <rexagod@gmail.com>
About Event in footer of judge and tracks page require change. |
ping @eldraco19 ==> #37 (comment) |
@karandevtyagi footer fixed in all pages with social links and quick links(they were missing in some pages) @rexagod Colorlib->JODC done! |
@eldraco19 JODC in footer still leads in colorlib. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also remove the colorlib
comments?
@rexagod @eldraco19 |
@rexagod @karandevtyagi |
@eldraco19 @rexagod @karandevtyagi @VARoDeK |
@eldraco19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make changes along the line of suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions:
- Use
align-content: flex-end
on the divs with the class "row" containing headings (About, Judges) to improve the awkward spacing issue - Deleting the "About" heading from the main page (index.html) improves the look of the website since it doesn't seem to be necessary, and it sticks out like a sore thumb compared to the other subheadings which have a white font and a red underline
@rexagod @eldraco19 I think after this we can Squash and merge this PR and can release Trident v1.0 |
@karandevtyagi |
PiedPiper got it. |
@eldraco19 |
@eldraco19 @rexagod |
@Ankk98 horizontal scroll fixed |
There's a spacing issue between the map and footer on venue page. PTAL. |
@eldraco19
I think after this PR we can go for a beta test @karandevtyagi @rexagod. |
@Ankk98 on it. |
Done #49 |
@rexagod spacing issue in venue page fixed |
I guess we should merge this now. I am leaving rest of the CSS issues for @JIITODC/trident-volunteers |
@eldraco19 🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥 |
Fixes: #36