Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images to team section #37

Merged
merged 14 commits into from
Mar 19, 2020
Merged

Conversation

eldracode
Copy link
Member

Fixes: #36

@karandevtyagi
Copy link
Member

@eldraco19 good work.Just reduce the space between heading and the content of page in every page which has excess space.This will make it good on phone as well.

Issue3

@eldracode
Copy link
Member Author

@karandevtyagi done!

@karandevtyagi
Copy link
Member

@eldraco19 Toggle to mobile devices in your dev tools and look at the extra spaces in complete website and remove them.Plus add credit to yourself in footer or add github repo link so that you can show this in future to someone or in resume if required.

@eldracode
Copy link
Member Author

@karandevtyagi on Desktop it looks fine, on mobile I tried to reduce as much as I can without affecting other components.

Old
old

New
new

index.html Outdated Show resolved Hide resolved
@rexagod
Copy link
Member

rexagod commented Mar 17, 2020

trident/index.html

Lines 525 to 536 in ec2f74e

<div class="col-md-12 text-center">
<div class="border-top pt-5">
<p>
<!-- Link back to Colorlib can't be removed. Template is licensed under CC BY 3.0. -->
Copyright &copy;
<script>document.write(new Date().getFullYear());</script> All rights reserved | This template is made
with <i class="icon-heart text-primary" aria-hidden="true"></i> by <a href="https://colorlib.com"
target="_blank">Colorlib</a>
<!-- Link back to Colorlib can't be removed. Template is licensed under CC BY 3.0. -->
</p>
</div>
</div>

Colorlib -> JIITODC? WDYT?

Copy link
Member

@rexagod rexagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

about.html Outdated Show resolved Hide resolved
about.html Outdated Show resolved Hide resolved
eldracode and others added 3 commits March 18, 2020 04:29
Co-Authored-By: Pranshu Srivastava <rexagod@gmail.com>
Co-Authored-By: Pranshu Srivastava <rexagod@gmail.com>
Co-Authored-By: Pranshu Srivastava <rexagod@gmail.com>
@karandevtyagi
Copy link
Member

About Event in footer of judge and tracks page require change.

@rexagod
Copy link
Member

rexagod commented Mar 18, 2020

ping @eldraco19 ==> #37 (comment)

@eldracode
Copy link
Member Author

@karandevtyagi footer fixed in all pages with social links and quick links(they were missing in some pages)

@rexagod Colorlib->JODC done!

@rexagod rexagod requested review from karandevtyagi and removed request for koderjoker March 18, 2020 11:19
@karandevtyagi
Copy link
Member

@eldraco19 JODC in footer still leads in colorlib.

Copy link
Member

@rexagod rexagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove the colorlib comments?

venue.html Outdated Show resolved Hide resolved
tracks.html Outdated Show resolved Hide resolved
judges.html Outdated Show resolved Hide resolved
diversity.html Outdated Show resolved Hide resolved
code-of-conduct.html Outdated Show resolved Hide resolved
about.html Outdated Show resolved Hide resolved
@rexagod rexagod requested review from koderjoker and Ankk98 March 18, 2020 11:33
@Ankk98
Copy link
Member

Ankk98 commented Mar 18, 2020

@rexagod @eldraco19
Have a look here: Colorlib Licence
"You are not allowed to remove the copyright credit from the footer."
So, add credits to both: colorlib and jodc.

@Ankk98
Copy link
Member

Ankk98 commented Mar 18, 2020

@rexagod @karandevtyagi
Suggestion:
I don't think we need to make another discord server for this. Instead add a channel in existing server and use the same. This will be more convinient.

@Ankk98
Copy link
Member

Ankk98 commented Mar 18, 2020

@eldraco19 @rexagod @karandevtyagi @VARoDeK
We need to add term and conditions also. Especially the one saying that all final rights remain with the organisers.

@Ankk98
Copy link
Member

Ankk98 commented Mar 18, 2020

@eldraco19
Registration button do not work: Add something saying registration will start soon.

Copy link
Member

@Ankk98 Ankk98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make changes along the line of suggestions.

about.html Outdated Show resolved Hide resolved
Copy link

@koderjoker koderjoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions:

  1. Use align-content: flex-end on the divs with the class "row" containing headings (About, Judges) to improve the awkward spacing issue
  2. Deleting the "About" heading from the main page (index.html) improves the look of the website since it doesn't seem to be necessary, and it sticks out like a sore thumb compared to the other subheadings which have a white font and a red underline

@eldracode
Copy link
Member Author

@Ankk98 added a popup in the registration button.
@rexagod Added both colorlib and JODC in the footer.

@karandevtyagi
Copy link
Member

karandevtyagi commented Mar 18, 2020

Suggestions:

  1. Use align-content: flex-end on the divs with the class "row" containing headings (About, Judges) to improve the awkward spacing issue
  2. Deleting the "About" heading from the main page (index.html) improves the look of the website since it doesn't seem to be necessary, and it sticks out like a sore thumb compared to the other subheadings which have a white font and a red underline
  • Add t&c

@rexagod @eldraco19 I think after this we can Squash and merge this PR and can release Trident v1.0

@Ankk98
Copy link
Member

Ankk98 commented Mar 18, 2020

@karandevtyagi
I think this would be v0.91 or something.
There are still some minor issues that we need to fix. I will add some of them as issues. Then we should be showing the website to others (beta test).
After that if we find it complete, then it should be v1(release).

@karandevtyagi
Copy link
Member

PiedPiper got it.

@Ankk98
Copy link
Member

Ankk98 commented Mar 18, 2020

@eldraco19
Kindly fix the inconsistent spacing between where-timeline , register-about etc.

@Ankk98
Copy link
Member

Ankk98 commented Mar 18, 2020

@eldraco19 @rexagod
About page and diversity and inclusion page are sideways scrollable/horizontally which is undesired.
Kindly fix it.

@eldracode
Copy link
Member Author

@Ankk98 horizontal scroll fixed

@eldracode
Copy link
Member Author

resolves #43
resolves #45
resolves #46
resolves #40
resolves #38
resolves #47

@rexagod
Copy link
Member

rexagod commented Mar 19, 2020

There's a spacing issue between the map and footer on venue page. PTAL.

@Ankk98
Copy link
Member

Ankk98 commented Mar 19, 2020

@eldraco19

  • Add a notice in the 'when' section that event has been postponed due to COVID-19 pandemic.
  • Add how to reach jiit-128 through the cab(Like dest address me exactly kya type karne se aayega) and nearest metro stations of all the 3 lines in the venue page.

I think after this PR we can go for a beta test @karandevtyagi @rexagod.

@Ankurk99
Copy link
Member

@Ankk98 on it.

@Ankurk99
Copy link
Member

Done #49

@eldracode
Copy link
Member Author

@rexagod spacing issue in venue page fixed

@eldracode
Copy link
Member Author

I guess we should merge this now. I am leaving rest of the CSS issues for @JIITODC/trident-volunteers
I will add the TnC page in another PR.

@karandevtyagi karandevtyagi merged commit bf43ad8 into JIITODC:gh-pages Mar 19, 2020
@rexagod
Copy link
Member

rexagod commented Mar 19, 2020

@eldraco19 🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥

@Ankk98 Ankk98 mentioned this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add images in "Our team" section
6 participants