Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKLOG-23059 Added lockInfo to node info query #268

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

r3dm1ke
Copy link
Contributor

@r3dm1ke r3dm1ke commented Jul 29, 2024

JIRA

https://jira.jahia.org/browse/BACKLOG-23059

Description

This PR adds some missing lockInfo fields to node info query.

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

Documentation

  • Inline documentation
  • Internal Documentation (wiki)
  • User-facing Documentation

@r3dm1ke r3dm1ke requested a review from a team July 29, 2024 19:37
AKarmanov
AKarmanov previously approved these changes Jul 29, 2024
Copy link
Contributor

@gflores-jahia gflores-jahia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we might take a performance hit if we just add to existing getLockInfo option as it's used in a lot of places, including checks for node drag and drop.

Let's keep a separate option instead to pull canLockUnlock info

@r3dm1ke r3dm1ke merged commit cef1e99 into master Jul 29, 2024
3 checks passed
@gflores-jahia gflores-jahia deleted the BACKLOG-23059 branch August 1, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants