Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA-15174 Make view prop nullable in preview query #272

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

r3dm1ke
Copy link
Contributor

@r3dm1ke r3dm1ke commented Sep 11, 2024

JIRA

https://jira.jahia.org/browse/QA-15174

Description

This PR makes the view prop nullable in the node preview query.

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

Documentation

  • Inline documentation
  • Internal Documentation (wiki)
  • User-facing Documentation

@r3dm1ke r3dm1ke requested a review from a team September 11, 2024 12:13
@r3dm1ke r3dm1ke merged commit 5ec0164 into master Sep 11, 2024
3 checks passed
@r3dm1ke r3dm1ke deleted the QA-15174 branch September 11, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants