-
-
Notifications
You must be signed in to change notification settings - Fork 20
Added spacemouse pro wireless bluetooth edition #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request adds support for the SpaceMouse Pro Wireless Bluetooth edition to the pyspacemouse library. The implementation involves adding a new device specification with its corresponding vendor ID, product ID, LED HID usage code pair, axis mappings, and button mappings. Class diagram showing the new SpaceMouse Pro Wireless Bluetooth device specificationclassDiagram
class DeviceSpec {
+String name
+List[int] hid_id
+List[int] led_id
+Dict mappings
+List[ButtonSpec] button_mapping
+float axis_scale
}
class AxisSpec {
+int channel
+int byte1
+int byte2
+int scale
}
class ButtonSpec {
+int channel
+int byte
+int bit
}
DeviceSpec -- AxisSpec: contains >
DeviceSpec -- ButtonSpec: contains >
note for DeviceSpec "New SpaceMouse Pro Wireless
Bluetooth device added with
specific mappings and buttons"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @koentjess - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please verify all device specification values (HID IDs, LED IDs, mappings) and provide documentation or testing evidence that confirms these values are correct for the SpaceMouse Pro Wireless Bluetooth device.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
The spacemouse pro wireless bluetooth edition seems to be missing, i'm not sure if all values are exactly what they are supposed to be but it seems to work.
Summary by Sourcery
New Features: