Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid removing snapshots and data files for Operation::Replace #154

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

SergeiPatiakin
Copy link
Contributor

Immediately removing snapshots and data files may disrupt concurrent readers who are still reading from the previous snapshot

@JanKaul
Copy link
Owner

JanKaul commented Apr 1, 2025

Thanks for bringing this up. You're right, the current implementation is too eager in deleting files. After reading into this topic, Iceberg only deletes the old files when an "ExpireSnaphost" operation is performed on the old snapshot. So this change definitely corrects the behavior of the "Replace" Operation.

Thanks for the PR.

@JanKaul JanKaul merged commit ea1d685 into JanKaul:main Apr 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants