Skip to content

Add an error for [I array] #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add an error for [I array] #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
145250b
Update array.jl
mcabbott Oct 16, 2024
ba0800c
Update Project.toml
mcabbott Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ChainRules"
uuid = "082447d4-558c-5d27-93f4-14fc19e9eca2"
version = "1.71.0"
version = "1.71.1"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
5 changes: 5 additions & 0 deletions src/rulesets/Base/array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,11 @@ end
# All the [hv]cat functions treat anything that's not an array as a scalar.
_catsize(x) = ()
_catsize(x::AbstractArray) = size(x)
_catsize(::LinearAlgebra.UniformScaling) = error(
"""ChainRules does not at present support *cat functions with LinearAlgebra.I
as it does not know how to calculate the size occupied in e.g. `[1:4 I 5:8]`.
Writing instead `[1:4 I(4) 5:8]` should work.
Issue tracking this is here: https://github.com/JuliaDiff/ChainRules.jl/issues/810""")

function rrule(::typeof(hcat), Xs...)
Y = hcat(Xs...) # note that Y always has 1-based indexing, even if X isa OffsetArray
Expand Down
Loading