Skip to content

Use package extensions #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use package extensions #90

wants to merge 1 commit into from

Conversation

schillic
Copy link
Member

@schillic schillic commented Jan 22, 2025

The only noticable change is that similar_type now creates a conflict when loading both this package and StaticArrays. At least I do not see how to work around this with package extensions. But maybe that is fair. In fact, the problem existed before; there was just no direct warning when using both packages, but the warning appeared when trying to access the symbol:

julia> using ReachabilityBase.Arrays

julia> using StaticArrays  # no warning here

julia> similar_type
ERROR: UndefVarError: `similar_type` not defined in `Main`
Hint: It looks like two or more modules export different bindings with this name, resulting in ambiguity. Try explicitly importing it from a particular module, or qualifying the name with the module it should come from.
Hint: a global variable of this name also exists in StaticArrays.

@schillic schillic force-pushed the schillic/extensions branch 2 times, most recently from 9334443 to 7b7b752 Compare January 23, 2025 16:49
@schillic schillic marked this pull request as ready for review January 23, 2025 17:02
@schillic schillic force-pushed the schillic/extensions branch from a3a8933 to d107ae9 Compare January 23, 2025 20:15
@schillic schillic changed the title Use package extensions and test StaticArrays code Use package extensions Jan 23, 2025
@schillic schillic added the breaking ❌ This change may break things label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking ❌ This change may break things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant