Reference Middleware and Strategy Headers via static
keyword instead of self
#189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes
CacheMiddleware
&GreedyCacheStrategy
are shipped with this package with specific header names set via class constant:guzzle-cache-middleware/src/CacheMiddleware.php
Lines 21 to 26 in 7f25853
guzzle-cache-middleware/src/Strategy/GreedyCacheStrategy.php
Line 22 in 7f25853
Extending these classes does not currently permit altering those values (unless the functionality altered in this PR are also overridden).
This change updates the references to these class constants to use the
static
keyword as opposed toself
to take advantage of PHP's Late Static Bindings feature.That way, custom implementations values are prioritized above the defaults for these headers.
I ran the automated test suite and it still passed for me.