Emulate VK_EXT_surface_maintenance1 if not supported by a driver #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Loader build queued with queue ID 263404. |
|
CI Vulkan-Loader build # 2719 running. |
|
CI Vulkan-Loader build # 2719 passed. |
The VK_EXT_surface_maintance1 extension is an instance level extension, which means the loader will advertise support for it when at least one driver supports it. However, there is presently no way for an application to know which VkPhysicalDevice's will fill out the structs the extension defines and which VkPhysicalDevice's will ignore the structs. Add support for testing the surface_maintenance1 implementation - making sure that a driver which supports the extension isn't affected and correctly filling out the structs for drivers which do and do not support vkGetPhysicalDeviceSurfaceCapabilities2KHR as well.
charles-lunarg
force-pushed
the
emulate_surface_maintenance_1
branch
from
5321a79 to
3c81a2c
Compare
|
CI Vulkan-Loader build queued with queue ID 263427. |
|
CI Vulkan-Loader build # 2720 running. |
|
CI Vulkan-Loader build # 2720 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VK_EXT_surface_maintance1 extension is an instance level extension, which means the loader will advertise support for it when at least one driver supports it. However, there is presently no way for an application to know which VkPhysicalDevice's will fill out the structs the extension defines and which VkPhysicalDevice's will ignore the structs.
Add support for testing the surface_maintenance1 implementation - making sure that a driver which supports the extension isn't affected and correctly filling out the structs for drivers which do and do not support vkGetPhysicalDeviceSurfaceCapabilities2KHR as well.