Add Duck IVF parsing support to the elementary stream. #18
Conversation
Signed-off-by: Vassili Nikolaev (NVIDIA) <vnikolaev@nvidia.com>
|
|
| #define DKIF_FRAME_CONTAINER_HEADER_SIZE 12 | ||
| #define DKIF_HEADER_MAGIC *((const uint32_t*)"DKIF") | ||
| #define DKIF_FILE_HEADER_SIZE 32 | ||
| #define USE_SIMPLE_MALLOC 1 |
There was a problem hiding this comment.
I'm a bit confused about this USE_SIMPLE_MALLOC. Can you add a comment to explain the use of that ?
| @@ -18,6 +18,10 @@ | |||
| #include <fstream> | |||
| #include "mio/mio.hpp" | |||
| #include "VkDecoderUtils/VideoStreamDemuxer.h" | |||
| #define DKIF_FRAME_CONTAINER_HEADER_SIZE 12 | |||
| #define DKIF_HEADER_MAGIC *((const uint32_t*)"DKIF") | |||
| #define DKIF_FILE_HEADER_SIZE 32 | |||
There was a problem hiding this comment.
would be nice to use structure and get some information from the header such as the codec.
You can get inspiration from https://github.com/Igalia/ESExtractor/blob/main/lib/eseivfstream.cpp
| FILE* handle = fopen(pFilePath, "rb"); | ||
| if (handle == nullptr) { | ||
| printf("Failed to open video file %s\n", pFilePath); | ||
| m_bitstreamDataSize = 0; |
There was a problem hiding this comment.
no need for that as its already set to null and zero above
|
|
||
| fseek(handle, 0, SEEK_END); | ||
| size_t size = ftell(handle); | ||
| uint8_t* data = (uint8_t*)malloc(size); |
There was a problem hiding this comment.
I would avoid this approach for very large file. I would read the size of the frame by the frame header and move the offset to this size.
|
|
||
| if (data == nullptr) { | ||
| printf("Failed to allocate memory for video file: %i\n", (uint32_t)size); | ||
| m_bitstreamDataSize = 0; |
There was a problem hiding this comment.
no need for this code as it hasnt been modified so far
| @@ -83,7 +130,11 @@ class ElementaryStream : public VideoStreamDemuxer { | |||
| } | |||
|
|
|||
| virtual ~ElementaryStream() { | |||
| #ifdef USE_SIMPLE_MALLOC | |||
|
We should remove the USE_SIMPLE_MALLOC from this change. @vasn1k, per our offline discussion, please do that before we merge this change. |
Add support for .ivf files when loading AV1 compressed video files and using elementary streams.