Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VulkanPerDrawContext::RecordCommandBuffer: use member vars #20

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

dabrain34
Copy link
Contributor

RecordCommandBuffer should use its own member values instead of passing it through its API.

Avoid vars shadowing detected by CTS

Fixes #19

RecordCommandBuffer should use its own member values instead
of passing it through its API.
@dabrain34 dabrain34 requested a review from zlatinski March 13, 2025 20:09
Copy link
Contributor

@zlatinski zlatinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @dabrain34! LGTM.

@zlatinski zlatinski merged commit 64c412a into main Mar 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RecordCommandBuffer in VulkanVideoUtils shadows VulkanPerDrawContext class members
2 participants