Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove laravel/legacy-factories dependency #2645

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

williamjallen
Copy link
Collaborator

laravel/legacy-factories provides support for the legacy Laravel factory() method which was removed in Laravel 8.x. This PR refactors the last remaining usage of this legacy method and removes the dependency.

@williamjallen williamjallen added this to the v3.8 milestone Jan 3, 2025
@williamjallen williamjallen marked this pull request as draft January 3, 2025 15:49
@williamjallen
Copy link
Collaborator Author

This PR is ready to be merged, but I have marked it as a draft until an upcoming PR which will conflict with it gets merged.

@williamjallen williamjallen marked this pull request as ready for review January 3, 2025 15:58
@williamjallen williamjallen added this pull request to the merge queue Jan 3, 2025
Merged via the queue into Kitware:master with commit 3e11a51 Jan 3, 2025
6 checks passed
@williamjallen williamjallen deleted the legacy-factories branch January 3, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants