Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usages of deprecated setMethods() method #2653

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

williamjallen
Copy link
Collaborator

The upgrade of PHPUnit to 10 and beyond is currently blocked by our usage of PHPUnit's deprecated setMethods() method which was removed in PHPUnit 10. This PR addresses all of our remaining usages of setMethods(), which clears the way for a PHPUnit upgrade in the near future.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josephsnyder josephsnyder added this pull request to the merge queue Jan 6, 2025
Merged via the queue into Kitware:master with commit 0f3d3b5 Jan 6, 2025
6 checks passed
@williamjallen williamjallen deleted the setMethods-replacement branch January 6, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants