Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for non-xml submission objects #2663

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

josephsnyder
Copy link
Member

When given a non-xml submission file, catch the exception of the bad submission and only reject the submission of the Validate setting is enabled.

Fixes: #2662

@josephsnyder josephsnyder force-pushed the catch_nonxml_submission_issues branch 2 times, most recently from 7101072 to 0f93331 Compare January 15, 2025 20:36
When given a non-xml submission file, catch the exception of the bad
submission and only reject the submission of the Validate setting is enabled.

Fixes: #2662
@josephsnyder josephsnyder force-pushed the catch_nonxml_submission_issues branch from 0f93331 to ab9abfd Compare January 15, 2025 20:52
@josephsnyder josephsnyder marked this pull request as ready for review January 16, 2025 14:47
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code here looks pretty reasonable overall. Can you add a test to ensure that no error is returned with a non-XML file is submitted, as well as a test to ensure that the error message added in this PR is displayed when submission validation is turned on?

app/Http/Controllers/SubmissionController.php Outdated Show resolved Hide resolved
app/cdash/include/ctestparser.php Outdated Show resolved Hide resolved
Co-authored-by: William Allen <16820599+williamjallen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submission of "extra" files no longer works
2 participants